This repository was archived by the owner on Nov 15, 2022. It is now read-only.
Add step to install uniffi-bindgen on README #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caiofaustino good addition to the docs but I need you to sign your commit, you can see below how to add a signing key to your git and github setup. Let me know if you need any help or if you don't have time to set it up I can sign your commit and merge it. |
This step exists in bdk-ffi readme, but is missing in this repo, and build.sh fails without it.
notmandatory
force-pushed
the
fix_readme_install_uniffi_bindgen
branch
from
8ee9c03 to
bd13eca
Compare
|
Ah thanks, sorry I didn't have much time lately to look into this, I'll make sure to configure signing my commits for the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This step exists in bdk-ffi readme, but is missing in this repo, and build.sh fails without it.