Skip to content
This repository was archived by the owner on Nov 15, 2022. It is now read-only.

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Jun 14, 2022

Description

This PR is the migration to bdk-ffi 0.7.0, and updates to the test suite.

Notes to the reviewers

Both test suites have been upgraded.

Checklist

@thunderbiscuit thunderbiscuit self-assigned this Jun 14, 2022
@thunderbiscuit thunderbiscuit added this to the Release 0.7.0 milestone Jun 14, 2022
@thunderbiscuit
Copy link
Member Author

The tests seem to fail because of the ring dependency (not coming from bdk directly nor from uniffir-rs so not exactly sure where).

error: failed to run custom build command for `ring v0.16.20`

@notmandatory
Copy link
Member

notmandatory commented Jun 15, 2022

I was able to reproduce this issue locally by changing my ANDROID_NDK_ROOT environment to the same as github actions seems to be using now. I suspect they changed it recently.

export ANDROID_NDK_ROOT=/home/steve/Android/Sdk/ndk/23.2.8568313

If in the test.yaml file you can hard code the environment variable to:

env:
     ANDROID_NDK_ROOT: /usr/local/lib/android/sdk/ndk/21.4.7075529

Then it should work. You can find the current github actions VM installed software versions here;

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5f2297e

@notmandatory notmandatory merged commit 5f2297e into bitcoindevkit:master Jun 15, 2022
@thunderbiscuit thunderbiscuit deleted the release/v0.7.0 branch August 18, 2022 02:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants