Skip to content

Conversation

reez
Copy link
Collaborator

@reez reez commented Mar 14, 2025

Updated to uniffi 0.29.0

  • Updated to 0.29.0 in Cargo.tomls
  • Added remote attribute and tried to update define_custom_string_type macro to match new custom type handling

@reez reez force-pushed the uniffi-0.29.0 branch 2 times, most recently from 0c095c0 to 0fdb014 Compare March 17, 2025 20:17
@reez reez force-pushed the uniffi-0.29.0 branch 2 times, most recently from 8f55a0f to 9ea7cdc Compare March 18, 2025 17:30
@reez reez marked this pull request as ready for review March 20, 2025 14:37
@reez reez requested a review from thunderbiscuit March 20, 2025 14:37
@thunderbiscuit
Copy link
Member

This looks ok to me, but I can't speak to the update of the macro. Is it the case that the panic now throws this error when attempting to use an invalid Txid in a method?

@reez
Copy link
Collaborator Author

reez commented Mar 20, 2025

Is it the case that the panic now throws this error when attempting to use an invalid Txid in a method?

Yep correct, when attempting to use an invalid Txid in a method it will throw the error message "Failed to parse Txid from string".

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 78432f8.

@reez reez merged commit 99db72b into bitcoindevkit:master Mar 20, 2025
7 checks passed
@reez reez deleted the uniffi-0.29.0 branch March 20, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants