fix(cross-platform): remove bitcoinjs deep imports from internals#61
Merged
fix(cross-platform): remove bitcoinjs deep imports from internals#61
Conversation
Reimplement bitcoinjs-lib internal helpers locally to not import from bitcoinjs-lib/src (which is error prone) so behavior stays stable across Node.js, CodeSandbox and React Native/Metro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/bitcoinjs-lib-internals.ts(tapleafHash,tapTweakHash,witnessStackToScriptWitness,isTaprootInput) using public APIs and deterministic local serialization.bitcoinjs-lib/src/*dependency in bundled output.src/tapMiniscript.tsto use publicpayments.p2trwithscriptTree + redeem.src/tapMiniscript.tsby introducing localTaptreetyping.test/bitcoinjsLibInternals.test.tsfor behavior parity and a dist guard against reintroducing deep runtime imports.src/tapTree.tsand bump package version to3.0.6.Why
Node, CodeSandbox and React Native/Metro resolve modules differently; deep imports and dynamic
requirefallbacks are brittle across environments. This change moves internals access (imports from bitcoinjs-lib/src/) to a stable, public-API-based path while preserving behavior.