Reduce bundle bloat and simplify backend plumbing#65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is mainly about two things: moving the noble-hashes dependency out of the default path so it can live as a peer dependency and simplifying the core by keeping a single internal
bitcoinLibinstance instead of threading it through every call.That singleton approach is safe because the
bitcoinjsandscurebackends expose the same internal contract for this library's needs. Both backends can do the job and the whole backend selection story is internal anyway, so this keeps the public API quieter and the code easier to follow.It also keeps the preset packages aligned with core, so the split stays predictable for users and for publishing.