Skip to content

Conversation

@thallium205
Copy link
Contributor

No description provided.

src/script.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please put an error message here, Not enough pubKeys provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 285a34b on thallium205:patch-2 into 4dd617d on bitcoinjs:master.

src/script.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary, the iteration of the array and pubKey.toBuffer() will check the types. However, if you are going to do this, please add 'Expected Array, got: ' + pubKeys.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per http://nodejs.org/api/assert.html#assert_assert_throws_block_error_message, error can be constructor, RegExp or validation function.
Please use RegExp: /Not enough pubKeys provided/.

edit: Also please add indentation

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 6c951e4 on thallium205:patch-2 into 4dd617d on bitcoinjs:master.

@dcousens
Copy link
Contributor

Thanks for adding the test, please squash to 1 commit after you fix the indentation, and please use the same commit style as the project.

@dcousens dcousens closed this May 28, 2014
@dcousens
Copy link
Contributor

Author re-opened as #198 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants