Stricter ecdsa RFC 6979 adherence #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Waiting on @jprichardson to release |
The previous impl. was in breach of the following section: > Please note that when k is generated from T, the result of bits2int is > compared to q, not reduced modulo q. If the value is not between 1 and > q-1, the process loops. > Performing a simple modular reduction would induce biases that would be > detrimental to signature security.
Member
|
Should be good now :p |
Contributor
Author
|
Cheers |
Actual range as per the RFC is [1, q - 1], the code adheres to this.
Member
|
I reviewed the RFC 6979 changes. Looks good to me. |
Contributor
Author
|
Thanks @jprichardson for the comments in IRC, included in above commits. |
Contributor
|
+1 |
kyledrake
added a commit
that referenced
this pull request
Jun 25, 2014
Stricter ecdsa RFC 6979 adherence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes
deterministicGenerateKto strictly adhere to the RFC rather than just step around the edge cases.Namely it avoids the following flaw in the current implementation (we were not looping):
This is not a critical security update, no security advisory is necessary.
Probability of bias is close to 1 in 2^128 and was known previously.