Skip to content

Conversation

@dcousens
Copy link
Contributor

This pull request switches from Crypto-JS's RIPEMD160 to the one now shipping with crypto-browserify.
This is preferred for two reasons:

  • We want to move away from Crypto-JS eventually
  • Consistent usage of Buffer
  • Only 1 more step to removing convert completely
  • Increased Node.js (local) performance

I added some test vectors for RIPEMD160 to ensure basic functionality, although it was already been cross-tested by hash160.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0%) when pulling f0370ef on dcousens:ripemd into 0198477 on bitcoinjs:master.

@kyledrake
Copy link
Contributor

Awesome!

kyledrake added a commit that referenced this pull request Jun 26, 2014
@kyledrake kyledrake merged commit 27ab41c into bitcoinjs:master Jun 26, 2014
@dcousens dcousens deleted the ripemd branch June 27, 2014 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants