Skip to content

Conversation

@dcousens
Copy link
Contributor

Any comments appreciated.

Listening for a response to browserify/sha.js#5 as well.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 912e944 on npmignore into 62ebacc on master.

weilu added a commit that referenced this pull request Jan 13, 2015
@weilu weilu merged commit 510212a into master Jan 13, 2015
@weilu weilu deleted the npmignore branch January 13, 2015 16:21
@fanatid
Copy link
Member

fanatid commented Feb 14, 2016

@dcousens jshint.json now is excess
Why not use files in package.json? Have nothing against .npmignore, just a curious.

@dcousens
Copy link
Contributor Author

@fanatid PR welcome. Agreed on all points.

@fanatid
Copy link
Member

fanatid commented Feb 15, 2016

@dcousens don't you mind if I also change keys order in package.json with order in package.json doc?

@dcousens
Copy link
Contributor Author

@fanatid sure? Is it necessary though?

@fanatid
Copy link
Member

fanatid commented Feb 15, 2016

@dcousens it isn't necessary, just personal preference

@dcousens
Copy link
Contributor Author

I don't really care what order. I just want it consistent across all the bitcoinjs/ projects (and maybe even mine dcousens/ haha).
Whatever you change, just, consistency 👍 .

@fanatid
Copy link
Member

fanatid commented Feb 15, 2016

.npmignore/files PR: #542
I also don't care about order, just want consistently everywhere. Since I use order from package.json docs, I trying do this everywhere 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants