Skip to content

Conversation

@fanatid
Copy link
Member

@fanatid fanatid commented Feb 15, 2016

Only src, because (from docs):

Certain files are always included, regardless of settings:

  • package.json
  • README (and its variants)
  • CHANGELOG (and its variants)
  • LICENSE / LICENCE

@fanatid fanatid mentioned this pull request Feb 15, 2016
.travis.yml Outdated
@@ -1,19 +1,21 @@
sudo: false
os:
- linux
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why linux?
I mean, I guess I always assumed this was the case, but, wouldn't it be default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, linux is os by default, but I can't find this in the travis docs. Should I remove this line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its overly verbose and doesn't serve any meaningful purpose. Personally.

@fanatid fanatid changed the title Feature/package.json files whitelist of files for npm package Feb 15, 2016
@fanatid fanatid force-pushed the feature/package.json-files branch from 4788ca7 to d9e4463 Compare February 15, 2016 07:48
@fanatid fanatid force-pushed the feature/package.json-files branch from d9e4463 to bed6ca0 Compare February 15, 2016 08:36
@fanatid
Copy link
Member Author

fanatid commented Feb 15, 2016

updated
@dcousens please check slack

dcousens added a commit that referenced this pull request Feb 15, 2016
@dcousens dcousens merged commit 2f2e500 into bitcoinjs:master Feb 15, 2016
@dcousens
Copy link
Contributor

Cheers @fanatid, great work :)

@dcousens dcousens self-assigned this Feb 15, 2016
@dcousens dcousens added this to the 2.3.0 milestone Feb 15, 2016
@fanatid fanatid deleted the feature/package.json-files branch February 15, 2016 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants