Skip to content

Allow for zeroed-out signatures #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from
Closed

Allow for zeroed-out signatures #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
6c2a869
TxBuilder: extract ExtractSignatures to free function
dcousens Dec 12, 2014
230e8dc
TxBuilder: re-order to avoid mutation in case of failure
dcousens Dec 12, 2014
0af7326
TxBuilder: sign now signs inputs in known publicKey order
dcousens Dec 12, 2014
6d41df4
TxBuilder: avoid var redeclaration due to hoisting
dcousens Jan 5, 2015
e35fb78
TxBuilder: rename prevOutMap to prevTxMap
dcousens Jan 5, 2015
5f66fcf
tests: add [failing] raw multisig fixture for TxBuilder
dcousens Jan 5, 2015
2f8c28a
tests: add [failing] test for nulldata signing
dcousens Jan 6, 2015
fa31c8c
tests: move TxBuilder.sign tests to fixtures
dcousens Jan 6, 2015
c8c36b9
TxBuilder: fix failing test for non-standard/multisig inputs
dcousens Jan 6, 2015
4dc20d6
TxBuilder: support signature re-ordering in fromTransaction
dcousens Jan 6, 2015
0ec832e
TxBuilder: extract isCoinbaseHash function
dcousens Jan 6, 2015
f248452
tests: consistent test data names
dcousens Jan 6, 2015
bf2656f
tests: update transaction fixture names to be consistent
dcousens Jan 28, 2015
c0b01bf
tests: add scriptHash(pubKey) test fixture
dcousens Jan 28, 2015
9f03ec6
tests: reduce setup-code duplication
dcousens Jan 28, 2015
fc246fb
tests: add non-standard input fixture
dcousens Jan 28, 2015
3021534
TxBuilder: replace switch lookup with object lookup
dcousens Feb 4, 2015
b2d93a7
TxBuilder: defer mutation as long as possible
dcousens Feb 4, 2015
3db6435
TxBuilder: missing redeemScript not an issue if already added
dcousens Feb 4, 2015
e255374
tests: add inconsistent hashType/redeemScript test
dcousens Feb 4, 2015
9a4db9e
tests: if description undefined, use exception
dcousens Feb 4, 2015
966264a
TxBuilder: add explanation for prevOutScript branch
dcousens Feb 4, 2015
d7edcea
Allow for missing signatures to be present as OP_0 in multisig input …
bpdavenport Feb 5, 2015
4bf4767
Fix style
bpdavenport Feb 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,11 @@ function isScriptHashOutput(script) {

function isMultisigInput(script) {
return script.chunks[0] === ops.OP_0 &&
script.chunks.slice(1).every(isCanonicalSignature)
script.chunks.every(function(chunk) {
// Allow for zeroed-out missing signatures
// See: https://github.com/bitcoin/bitcoin/blob/f425050546644a36b0b8e0eb2f6934a3e0f6f80f/src/script/sign.cpp#L195-L197
return chunk === ops.OP_0 || isCanonicalSignature(chunk);
})
}

function isMultisigOutput(script) {
Expand Down
Loading