scripts: add allowIncomplete for multisig scripts #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
force-pushed
the
wipscript
branch
2 times, most recently
from
461610e to
f221545
Compare
Contributor
Author
There was a problem hiding this comment.
null is re-interpreted as OP_0 as seen on line 148.
Contributor
Author
There was a problem hiding this comment.
this type is used when the allowIncomplete flag is true
dcousens
added a commit
that referenced
this pull request
Feb 13, 2015
scripts: add allowIncomplete for multisig scripts
This was referenced Feb 15, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @bpdavenport for the initial implementation of this, however there was some issues with the existing implementation in f7604b8 that meant all multisig signatures were considered complete even though they weren't.
To allow for this without breaking backwards compatibility, I have added the
allowIncompleteflag and appropriate tests.@bpdavenport does this look good to you?
This should bode well with the
txbmergechanges and ideally be merged in the next 24 hours.