use standardjs formatting #364
Conversation
|
The PR is much smaller when you consider ?w=0 |
There was a problem hiding this comment.
toString invokes affineX in a way that doesn't annoy standard
|
@jprichardson thoughts? |
|
Seems @coveralls wasn't showing us the coverage loss in using the one-liner if statements. |
dcousens
force-pushed
the
standard
branch
2 times, most recently
from
27b10ea to
014e2ca
Compare
|
Rebased on master. @kyledrake, @weilu thoughts appreciated. Hoping to merge by Wednesday 25th. |
Thoughts on Standard? Ya, it's great. Assuming you're talking about |
|
@jprichardson no no, I was just annotating why there was an actual code change there. I was just after your thoughts on standard. Happy to discuss any concerns post merge. |
There was a problem hiding this comment.
Standard-format artifact. @maxogden?
On 1 Mar 2015 3:11 pm, "Wei Lu" notifications@github.com wrote:
In src/ecdsa.js
#364 (comment)
:@@ -146,7 +146,7 @@ function verifyRaw(curve, e, signature, Q) {
if (r.signum() <= 0 || r.compareTo(n) >= 0) return false
if (s.signum() <= 0 || s.compareTo(n) >= 0) return false
- // c = s^-1 mod n
// c = s^-1 mod nwat? why?
—
Reply to this email directly or view it on GitHub
https://github.com/bitcoinjs/bitcoinjs-lib/pull/364/files#r25563881.
There was a problem hiding this comment.
@maxogden, another example of this weird comment indentation artifact
|
👍 |
Simple enough PR, use https://github.com/feross/standard for formatting and styling.
The changes were minimal, with manual intervention over
standard --formatneeded mostly around the mocha globals and extra if statement padding.