-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Integration tests: replace cb-helloblock with cb-insight and cb-blockr #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This closes #399 |
test/integration/utils.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this just go on forever?
|
ACK, LGTM. Unless @rubensayshi can give us a way to integrate with https://www.blocktrail.com/ that doesn't require an API token, I'm happy with this. @rubensayshi perhaps allow non-authenticated requests but just have them severely rate limited? edit: That said, I don't like that that we have two libraries, but that will change in time. |
|
Looks good, other than @weilu butchering my precious faucet :p |
|
@jprichardson FML haha your faucet needs more |
|
Tests still failing? |
|
Tests pass. Looks good. Can we hold out on a response from @rubensayshi before merge? |
|
sure. |
Integration tests: replace cb-helloblock with cb-insight and cb-blockr
|
Merging, @rubensayshi feel free to comment on the above. |
Blockr flips out on tx propagation sometimes, so using cb-insight for that. Why not use cb-insight for everything? Well, it doesn't support getting multiple transactions, yet. Feature wise, cb-blockr is still more complete. I'm also using a patched version of cb-insights, because latest version in npm does not 1) support transaction.get and 2) include unconfirmed amount in address.summary.
https://coconut-macaroon.herokuapp.com/ is just a faucet I spawn up with @jprichardson's neat bitcoin-faucet (patched as well :P)