Skip to content

Conversation

@weilu
Copy link
Contributor

@weilu weilu commented May 30, 2015

Blockr flips out on tx propagation sometimes, so using cb-insight for that. Why not use cb-insight for everything? Well, it doesn't support getting multiple transactions, yet. Feature wise, cb-blockr is still more complete. I'm also using a patched version of cb-insights, because latest version in npm does not 1) support transaction.get and 2) include unconfirmed amount in address.summary.

https://coconut-macaroon.herokuapp.com/ is just a faucet I spawn up with @jprichardson's neat bitcoin-faucet (patched as well :P)

@weilu
Copy link
Contributor Author

weilu commented May 30, 2015

This closes #399

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this just go on forever?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.42% when pulling 713f038 on replace-cb-helloblock into 3532fce on master.

@dcousens
Copy link
Contributor

ACK, LGTM.

Unless @rubensayshi can give us a way to integrate with https://www.blocktrail.com/ that doesn't require an API token, I'm happy with this.

@rubensayshi perhaps allow non-authenticated requests but just have them severely rate limited?

edit: That said, I don't like that that we have two libraries, but that will change in time.

@jprichardson
Copy link
Member

Looks good, other than @weilu butchering my precious faucet :p

@weilu
Copy link
Contributor Author

weilu commented May 30, 2015

@jprichardson FML haha your faucet needs more patching butchering -- doesn't handle p2sh address man.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.42% when pulling 70d423f on replace-cb-helloblock into 3532fce on master.

@dcousens
Copy link
Contributor

Tests still failing?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.42% when pulling 9a921ad on replace-cb-helloblock into 3532fce on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.42% when pulling 4028bd5 on replace-cb-helloblock into 3532fce on master.

@dcousens
Copy link
Contributor

Tests pass. Looks good. Can we hold out on a response from @rubensayshi before merge?

@weilu
Copy link
Contributor Author

weilu commented May 30, 2015

sure.

dcousens added a commit that referenced this pull request Jun 1, 2015
Integration tests: replace cb-helloblock with cb-insight and cb-blockr
@dcousens dcousens merged commit 768ed69 into master Jun 1, 2015
@dcousens dcousens deleted the replace-cb-helloblock branch June 1, 2015 01:56
@dcousens
Copy link
Contributor

dcousens commented Jun 1, 2015

Merging, @rubensayshi feel free to comment on the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants