Skip to content

Conversation

@Copinmalin
Copy link
Contributor

No description provided.

@Copinmalin
Copy link
Contributor Author

Copinmalin commented Dec 24, 2023

@bitschmidty @murchandamus can you help me with this error please ?

- ./_site/fr/newsletters/2023/12/20/index.html

  *  linking to internal hash #bitcoinsearch.xyz that does not exist (line 250)

     <a href="/fr/newsletters/2023/02/15/#bitcoinsearch.xyz">lancé</a>

htmlproofer 3.15.0 | Error:  HTML-Proofer found 1 failure!

I found this diff in french newsletter :
<p><a href="[https://bitcoinsearch.xyz/](view-source:https://bitcoinsearch.xyz/)">BitcoinSearch.xyz</a> est un moteur de recherche

and english version :

<ul>
  <li id="bitcoinsearch-xyz" class="anchor-list"><a href="[#bitcoinsearch-xyz](view-source:https://bitcoinops.org/en/newsletters/2023/02/15/#bitcoinsearch-xyz)" class="anchor-list-link">●</a> <a href="[https://bitcoinsearch.xyz/](view-source:https://bitcoinsearch.xyz/)">BitcoinSearch.xyz</a> is a recently-

@murchandamus
Copy link
Collaborator

murchandamus commented Dec 26, 2023

@bitschmidty @murchandamus can you help me with this error please ?

I think I found it. It seems to me that the original mention of BitcoinSearch in February had been missing the dash at the start of the paragraph. That caused the internal anchor not to be created. Thanks for working on this, Merry Christmas!

@bitschmidty
Copy link
Contributor

Pushed a small commit to removing trailing space and fix the build. @Copinmalin let me know when the newsletter is ready for review and out of draft mode.

@Copinmalin Copinmalin marked this pull request as ready for review December 26, 2023 17:26
@Copinmalin
Copy link
Contributor Author

Thanks for your help @bitschmidty @murchandamus

@murchandamus
Copy link
Collaborator

I noticed that the title differed from the prior years, and that the excerpt variable had been translated. I renamed it to the original which fixed the intro paragraph.

@murchandamus
Copy link
Collaborator

Scrolled over it, now looks good visually. Did not check all the links this time, there are too many.

@murchandamus murchandamus merged commit a0ff166 into bitcoinops:master Dec 26, 2023
@murchandamus
Copy link
Collaborator

I checked a few links and scrolled over it a bit slower one more time. LGTM, we can fix any minor issues that might still be discovered. Thanks @Copinmalin and @Jluc-bitcoinfr

@Copinmalin Copinmalin deleted the Newsletter-282-Translate-into-French branch December 29, 2023 11:34
harding pushed a commit to harding/bitcoinops.github.io that referenced this pull request Sep 27, 2024
* Create 2023-12-20-newsletter.md

* Update 2023-12-20-newsletter.md

* Update 2023-12-20-newsletter.md

* Update 2023-12-20-newsletter.md

* Update 2023-12-20-newsletter.md

* Update 2023-12-20-newsletter.md

* Update 2023-12-20-newsletter.md

* Update 2023-12-20-newsletter.md

* Update 2023-12-20-newsletter.md

* Update 2023-12-20-newsletter.md

* Fix missing slug and internal link

* Spacing fixup

* Match annual review title to prior years

* Fix translated variable

---------

Co-authored-by: Jluc-bitcoinfr <bitcoin.fr@gmail.com>
Co-authored-by: Murch <murch@murch.one>
Co-authored-by: Mike Schmidt <schmidty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants