Skip to content

Newsletter-49: translate into Chinese#1812

Merged
bitschmidty merged 14 commits intobitcoinops:masterfrom
bittomhan:2019-06-05-newsletter-zh-49
Aug 19, 2024
Merged

Newsletter-49: translate into Chinese#1812
bitschmidty merged 14 commits intobitcoinops:masterfrom
bittomhan:2019-06-05-newsletter-zh-49

Conversation

@bittomhan
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thank you @bittomhan

Copy link
Copy Markdown
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bittomhan Actually I now noticed a visual formatting issue with the lightning include. I looked at the /en/ version for reference and I think the spacing may help.

Comment thread _includes/specials/2019-exec-briefing/zh/lightning.md Outdated
Comment thread _includes/specials/2019-exec-briefing/zh/lightning.md Outdated
Comment thread _includes/specials/2019-exec-briefing/zh/lightning.md Outdated
Comment thread _includes/specials/2019-exec-briefing/zh/lightning.md Outdated
bittomhan and others added 5 commits August 12, 2024 19:13
Co-authored-by: Mike Schmidt <schmidty@gmail.com>
Co-authored-by: Mike Schmidt <schmidty@gmail.com>
Co-authored-by: Mike Schmidt <schmidty@gmail.com>
Co-authored-by: Mike Schmidt <schmidty@gmail.com>
@bittomhan
Copy link
Copy Markdown
Contributor Author

Yes after that fix, the ZH version looks like this:

Screenshot 2024-08-12 at 9 36 27 PM

Althought it failed on the remote check, but it works well on local:
Screenshot 2024-08-12 at 9 36 10 PM

I try to change some part back:
Screenshot 2024-08-12 at 9 42 22 PM

It also works well on local:
Screenshot 2024-08-12 at 9 37 10 PM

Maybe there are any bugs there? or the remote check should re-try.

@bittomhan
Copy link
Copy Markdown
Contributor Author

I really do not know what happened? Can you help me?

@bittomhan Actually I now noticed a visual formatting issue with the lightning include. I looked at the /en/ version for reference and I think the spacing may help.

@bittomhan
Copy link
Copy Markdown
Contributor Author

I really do not know what happend

@bitschmidty
Copy link
Copy Markdown
Contributor

The spacing issue is still not fixed. You can see the en lightning.md has two spaces the results in the correct formatting. Currently you have one space leading the lines.

Here is a commit with the correct spacing (I dont have permission to push to your repo): bitschmidty@9c20606

Copy link
Copy Markdown
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you correct for the rest of the items per the example I suggested?

Comment thread _posts/zh/newsletters/2019-06-05-newsletter.md Outdated
@bittomhan
Copy link
Copy Markdown
Contributor Author

The spacing issue is still not fixed. You can see the en lightning.md has two spaces the results in the correct formatting. Currently you have one space leading the lines.

Here is a commit with the correct spacing (I dont have permission to push to your repo): bitschmidty@9c20606

I checked the error and try to add link for the [Erlay] and finally it works.
I suppose this is also something for the environment difference for the ZH and EN files to run and ZH files failed to integrate the un-list links with default links after it changed some format.

@bittomhan bittomhan requested a review from bitschmidty August 17, 2024 11:45
Copy link
Copy Markdown
Contributor

@bitschmidty bitschmidty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@bitschmidty bitschmidty merged commit 8fcdb5f into bitcoinops:master Aug 19, 2024
@bittomhan bittomhan deleted the 2019-06-05-newsletter-zh-49 branch August 19, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants