-
Notifications
You must be signed in to change notification settings - Fork 145
Bump ruby to 3.4 and fix Travis CI #2577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Build with dev config first (correct URL), then serve --skip-initial-build. jekyll serve --host 0.0.0.0 otherwise overrides site.url to 0.0.0.0.
|
In #1438 (comment) it is mentioned that |
Required for Ruby 3.1+ where Psych 4 disables YAML aliases by default and restricts class instantiation. See https://bugs.ruby-lang.org/issues/17866
|
Draft while I'm figuring out the netlify CI issue where it's trying to compile ruby from source and timing out doing so: https://app.netlify.com/projects/bitcoinops/deploys/69305bd1a6665b0008b32efe |
edf2ec7 to
1f7b6fd
Compare
Ruby 2.6 has become EOL since 2022. Bump it to the latest stable version. Also update the lockfile and dependencies.
Ruby 2.6 has become EOL since 2022. Bump it to the latest stable version. Also update the lockfile and dependencies.
Replace deprecated `/` division with `calc()` to fix Dart Sass 2.0 deprecation warnings. See https://sass-lang.com/d/slash-div
- quiet_deps: suppress warnings from dependencies (minima theme) - silence @import deprecation: migration to @use/@forward requires significant minima refactoring (tracked: https://sass-lang.com/d/import)
Change `//github.com/` to `https://github.com/` to ensure links work correctly and pass html-proofer validation.
The timestamp seek buttons used anchor tags without href attributes, relying solely on onclick handlers. Add href="javascript:void(0)" to make them valid anchors for html-proofer.
- Remove --check-html (deprecated in 4.0+) - Rename --url-ignore to --ignore-urls - Add --no-enforce-https (5.x now enforces https by default)
|
Undrafting, it seems like this PR is ready: local builds (e.g. The Netlify job failing is because of a cache issue that can be addressed by either clearing the site-wide Netlify cache (may cause issues for branches still on Ruby 2.6.4), by re-running this job without cache, or by increasing the build timeout so compilng Ruby from source doesn't fail. Specifically, the cache issue is that even though the |
|
@stickies-v Taking a look at this and will try to get it working locally. Thanks for your work on this! |
bitschmidty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to get this working on my machine locally (no docker).
Tested:
- build processes (preview, production, all, clean)
- ensured the preview auto regenerated based on file changes
- built with
JEKYLL_ENV=email make clean preview(for the email version) and smoke tested - tested the updated podcast seek links
- smoke tested various pages in the site
Pushed a commit that fixed a bunch of warnings from the new version of Jekyll around non-ASCII slugs.
@azuchi @Gustavojfe you might have a test on your setups as well
|
This is good improvement. The builds are successful in my local environment(Ubuntu 24.04.3 LTS). @bitschmidty Thanks also for fixing the slug warnings. |
|
Tentative plan, if all goes well from reviewers, is to merge this after the year in review newsletter. That will give us a week+ of downtime from new newsletter publications for contributors to get their respective local environments working with the new versions from this PR. That likely means translations will be the first new PRs after the updates. So @azuchi @Copinmalin @hulatown, heads up that this is coming and perhaps prepare some time to update your local development environments at that point. For myself, I have one of my computers setup for this PR's new dev environment for testing and another computer for working in the current setup. Other contributors may have to setup docker or other ways of testing this PR without nuking their current setups in the meantime. cc: @murchandamus |
Bumps Ruby to 3.4 and closes #1437 by fixing the Travis CI job.
Ruby 2.6 became EOL in 2022, so we should bump it. I think going straight to the latest stable (3.4) makes sense, but I'm very unfamiliar with the Ruby ecosystem. We should also bump the ruby version on the server where this website is hosted, but I think that's done outside of this repo? Ideally the ruby versions are identical so local and CI builds mirror what's actually going live.
One side-effect of the EOL ruby version is that
docker compose upno longer works without cached dependencies:build log
Changes in this PR:
To review:
PLATFORMSto justrubyon purpose.Alternative to #2470 by not relying on EOL software. Also see #1438.