Newsletters: add 97 (2020-05-13) by harding · Pull Request #401 · bitcoinops/bitcoinops.github.io

harding · 2020-05-10T15:18:55Z

Have a happy halving everyone!

Update releases section Tuesday afternoon @harding
Bitcoin Core PR Review Club section @jnewbery or @jonatack
C-Lightning #3659 @moneyball
Rust-Lightning #539 @dongcarl

jonatack

Thanks @harding, TIL about Sanders' attack. First-pass review comments below.

jonatack · 2020-05-10T16:55:16Z

+    into thinking that its balance was increasing when it was actually
+    decreasing.  An attacker would create an unsigned transaction
+    spending two of the hardware wallet's inputs to two outputs---one
+    output paying paying the wallet slightly more than the larger of the


double-spending of the word "paying" here :)

jonatack · 2020-05-10T16:56:06Z

+    would ask for a signature on the first input (without disclosing that the
+    second input belonged to the wallet); the wallet would sign that
+    input after verifying that the output paying back into the wallet
+    was larger than the input.  Then the attacker would then ask for a


Can remove one of the two "then"s, most likely the first one: s/Then the/The/

jonatack · 2020-05-10T16:59:44Z

+    inputs,[^outpoint-txid-spk] but making it directly in the
+    transaction digest would allow a [Partially Signed Bitcoin
+    Transaction][topic psbt] (PSBT) to trustlessly provide signers with
+    a copy of all scriptPubKeys being spent in a transaction.  That


s/That/This/ -- though a more specific description might be better.

jonatack · 2020-05-10T17:01:15Z

+    a copy of all scriptPubKeys being spent in a transaction.  That
+    would be trustless because, if any of the scriptPubKeys were missing
+    or modified, the signer's commitment to the scriptPubKeys would be
+    invalid, making the transaction invalid.  This allow would hardware


s/allow would/would allow/

jonatack · 2020-05-10T17:03:35Z

+  messages in both the locale's language and in English.  This can help
+  users find help and quickly describe the problem to developers.
+  Additionally, the English version of the error message is now what
+  gets written to the debug log, again to make it easier for developers


"is now what gets written" seems a bit informal here

jonatack · 2020-05-10T17:05:25Z

+[^outpoint-txid-spk]:
+    In the existing [BIP341][] specification of [taproot][topic
+    taproot], each input commits to the outpoints of every input
+    included in the transaction.  Outpoints are the concatenated txid


maybe: transaction id (txid)

does "concatenated" here apply to both the txid and the vout?

Removing the word "concatenated" to hopefully make it clearer. "Txid" is one of our unintroduced abbreviations in the style guide, and I continue to think most technical readers will be familiar with that term.

"Txid" is one of our unintroduced abbreviations in the style guide, and I continue to think most technical readers will be familiar with that term.

Got it 👍 will keep that list in mind

jonatack · 2020-05-10T17:06:58Z

+    included in the transaction.  Outpoints are the concatenated txid
+    and output index (vout) of the output being spent.  Txids are a hash
+    of most parts of the transaction containing that output.  So a
+    commitment to a outpoint is a commitment to a txid which is a


an outpoint

jonatack · 2020-05-11T11:53:04Z

ACK -- edits look good.

jnewbery · 2020-05-11T16:59:06Z

I've added the PR Review Club section, including a small change to the details-list function to include an external link. I used the wikipedia external link icon, which I think is fine to reuse: https://commons.wikimedia.org/wiki/File:Icon_External_Link.png.

The link works on the web build, but for some reason the :after CSS doesn't appear in the email build. I haven't tested with an RSS reader.

No comments on the other newsletter content. Looks great to me 👍

harding

A few nits on the PR review club changes. I'm going to push a commit that makes the suggested change for the external link icon because that also fixes the email preview---but @jnewbery (or anyone else), please feel free to revert if you really want the Wikipedia external link icon (which I do think is a better signal to users but worse for copy/pasting). Thanks!

harding · 2020-05-11T17:02:17Z

 requests in the Bitcoin Core, LND, C-Lightning, libsecp256k1, BIPs, BOLTs,
-and Rust-Lightning repositories.
+and Rust-Lightning repositories, and Bitcoin Core PR Review Club archive
+pages.


Nit: two final "ands" here. At this point, we can probably just remove the list of repositories and let anyone interested read the code. With each repository on a separate line, I think it's easy enough to figure out.

harding · 2020-05-11T17:11:59Z

  {% assign qslug = include.[q] | slugify: 'latin' %}
  {% if jekyll.environment == "email" %}
-   - <i markdown="1">{{include.[q]}}</i><br>{{include.[a]}}
+   - <i markdown="1">{{include.[q]}}</i><br>{{include.[a]}} {{alink}}


I think a   would be better than a regular space so that the external link icon doesn't appear on a line by itself.

Agree -- a non-breaking space here would be good.

harding · 2020-05-11T17:19:16Z

 }
+
+a.external:after {
+  content: url("/img/Icon_External_Link.png");


Maybe use ➚ instead since it's unicode and so should copy automatically when @bitschmidty makes the newsletter email (I believe he needs to copy any images?). Its HTML entity coding is ➚

jnewbery · 2020-05-11T17:44:21Z

@harding - yeah, I got caught up and was trying to be too clever to include the wikipedia external link icon. Using a standard unicode code point makes much more sense.

adamjonas

A few minor observations. 👍 the PR review section.

adamjonas · 2020-05-11T17:58:24Z

+  a0link="https://bitcoincore.reviews/17994.html#l-33"
+
+  q1="Is it possible to create the undo data for a block without having all the
+      preceeding blocks?"


Suggested change

preceeding blocks?"

preceding blocks?"

adamjonas · 2020-05-11T17:58:34Z

+      preceeding blocks?"
+  a1="No. Creating the undo data for a block requires having the UTXO set at
+      the point that the block was connected. For that, we need to have
+      validated and connected all preceeding blocks."


Suggested change

validated and connected all preceeding blocks."

validated and connected all preceding blocks."

adamjonas · 2020-05-11T17:58:53Z

+  the hardware wallet to automatically participate in [coinjoin][topic
+  coinjoin] transactions or LN payment routing.
+
+    However, several years ago Greg Sanders [described][sanders safe


Suggested change

However, several years ago Greg Sanders [described][sanders safe

However, several years ago, Greg Sanders [described][sanders safe

jonatack

ACK review club quiz content (modulo s/preceeding/preceding/)

jonatack · 2020-05-11T19:29:01Z

  {% assign qslug = include.[q] | slugify: 'latin' %}
  {% if jekyll.environment == "email" %}
-   - <i markdown="1">{{include.[q]}}</i><br>{{include.[a]}}
+   - <i markdown="1">{{include.[q]}}</i><br>{{include.[a]}} {{alink}}


Agree -- a non-breaking space here would be good.

harding · 2020-05-12T09:40:42Z

Pushed some edits, all small except for a rewrite of one sentence from the PR Club overview paragraph. Thanks @jnewbery, @adamjonas, and @jonatack for the reviews! ACK @moneyball PR description (thanks for researching that!) and @dongcarl PR description (excellent write-up, thanks!)

bitschmidty

ACK

Tested the email version as well (regarding small changes from 88e8a54 )

jnewbery · 2020-05-12T20:11:12Z

+UTXO set is updated to reflect the transactions in a new block; if the
+block is later removed during a reorg, the undo file contains the
+changes that will restore the UTXO set to its previous state, undoing
+the effects of originally processing the block.


Much better. Harding, you're a word 🧙‍♂️ .

jnewbery

One small nit, but otherwise all LGTM

jnewbery · 2020-05-12T20:15:33Z

+  to comprehend the problem and provide assistance.
+
+- [C-Lightning #3659][] has `channeld` create the penalty transaction, as
+  it has enough information about previous commitment transactions to create


nit: 'to create it' seems a little redundant.

bitschmidty · 2020-05-13T12:14:04Z

Squashed and added a small change changing internal link to relative from absolute

bitschmidty · 2020-05-13T12:32:59Z

Another chunk of a newsletter, thanks to the team! @harding @jonatack @moneyball @jnewbery @dongcarl with the 🖊️ and @adamjonas with the 🔍

jonatack reviewed May 10, 2020

View reviewed changes

harding commented May 11, 2020

View reviewed changes

adamjonas reviewed May 11, 2020

View reviewed changes

jonatack reviewed May 11, 2020

View reviewed changes

bitschmidty reviewed May 12, 2020

View reviewed changes

jnewbery reviewed May 12, 2020

View reviewed changes

harding and others added 6 commits May 13, 2020 06:26

Newsletters: add 97 (2020-05-13)

9329597

News: Add external link to review club Q&As

035a399

News: Add Review Club to references and issues linkers

27eea65

News97: Add review club summary

f6b38c5

News97: add C-Lightning PR 3659

43828a9

News97: Add Rust-Lightning 539 description

038ee2a

bitschmidty force-pushed the 2020-05-13-newsletter branch from c6eceb7 to 038ee2a Compare May 13, 2020 12:04

bitschmidty merged commit 4784ba7 into bitcoinops:master May 13, 2020

hulatown pushed a commit to PrimitivesLane/bitcoinops.github.io that referenced this pull request Apr 17, 2026

Translate newsletter bitcoinops#401 into Chinese

ed91a46

hulatown mentioned this pull request Apr 17, 2026

Newsletter-401: translate into Chinese PrimitivesLane/bitcoinops.github.io#218

Open

hulatown pushed a commit to PrimitivesLane/bitcoinops.github.io that referenced this pull request Apr 21, 2026

Translate newsletter bitcoinops#401 into Chinese

89410ca

	validated and connected all preceeding blocks."
	validated and connected all preceding blocks."

	However, several years ago Greg Sanders [described][sanders safe
	However, several years ago, Greg Sanders [described][sanders safe

Conversation

harding commented May 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonatack commented May 11, 2020

Uh oh!

jnewbery commented May 11, 2020

Uh oh!

harding left a comment

Choose a reason for hiding this comment

Uh oh!

harding May 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jnewbery commented May 11, 2020

Uh oh!

adamjonas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harding commented May 12, 2020

Uh oh!

bitschmidty left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jnewbery left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bitschmidty commented May 13, 2020

Uh oh!

bitschmidty commented May 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

harding commented May 10, 2020 •

edited

Loading

harding May 11, 2020 •

edited

Loading

adamjonas left a comment •

edited

Loading