New topic: vaults#411
Conversation
bitschmidty
left a comment
bitschmidty
left a comment
There was a problem hiding this comment.
Thanks @harding couple small suggestions
jnewbery
force-pushed
the
2020-06-new-topic-vaults
branch
from
3f0ecc8 to
9f4c5f6
Compare
|
I've rebased and added the vaults links to the |
harding
force-pushed
the
2020-06-new-topic-vaults
branch
from
9f4c5f6 to
1d10c3c
Compare
|
ACK 1d10c3c |
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
Looks good. A few very minor suggested changes.
| ## Required. Use Markdown formatting. Only one paragraph. No links allowed. | ||
| ## Should be less than 500 characters | ||
| excerpt: > | ||
| **Vaults** are a type of covenant that requires two separate |
There was a problem hiding this comment.
Should this be 'require' to agree with 'vaults'. Alternatively: "A vault is a type of covenant that requires"
|
|
||
| ## Optional. Use Markdown formatting. Multiple paragraphs. Links allowed. | ||
| extended_summary: | | ||
| Usually, there's a minimum amount of time or number of blocks that |
There was a problem hiding this comment.
There seems to be some difference between the excerpt "transactions ... appear in two different blocks" and this "Usually, there's a minimum amount of time or blocks".
The first states that the transactions must appear in different blocks. The second implies with the "usually" that there could be cases where the transactions appear in the same block.
| Some vault designs rely on [covenants][topic covenants] that require | ||
| consensus changes to Bitcoin. Other vault designs use existing | ||
| protocol features plus techniques such as multisig, presigned | ||
| transactions, and ephemeral private keys. |
There was a problem hiding this comment.
I don't think 'ephemeral' emphasizes the right thing. The critical part is that the keys are deleted.
harding
force-pushed
the
2020-06-new-topic-vaults
branch
from
1d10c3c to
cc2e3a7
Compare
harding
force-pushed
the
2020-06-new-topic-vaults
branch
from
cc2e3a7 to
9891a73
Compare
3 participants
No description provided.