New topic: OP_CHECKTEMPLATEVERIFY#412
Merged
Merged
Conversation
Contributor
|
ACK 7cde3ed |
7cde3ed to
04d391b
Compare
Contributor
|
Rebased on master and added the link to the op_checktemplateverify topic from the op_checksigfromstack topic. |
jnewbery
reviewed
Jun 3, 2020
jnewbery
left a comment
Contributor
There was a problem hiding this comment.
ACK. Just a couple of questions on the links.
| use case rather than providing a [flexible][corallo flex] and | ||
| [generic][oconnor generic] covenant capability. | ||
|
|
||
| [maxwell-attributed specific]: https://bitcointalk.org/index.php?topic=5220520.msg53711340#msg53711340 |
Contributor
There was a problem hiding this comment.
This links to greg complaining about the process rather than the proposal. Is that what you meant to link to?
Collaborator
Author
There was a problem hiding this comment.
Nope. I meant to link to the post above; thanks for catching that!
| [generic][oconnor generic] covenant capability. | ||
|
|
||
| [maxwell-attributed specific]: https://bitcointalk.org/index.php?topic=5220520.msg53711340#msg53711340 | ||
| [corallo flex]: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-May/016936.html |
Contributor
There was a problem hiding this comment.
I suggest we drop this link. I think the Russell O'Connor critique on flexibility and genericness is much more constructive and informative.
04d391b to
9832ccc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.