Open
Conversation
kouloumos
reviewed
Jul 17, 2024
Member
kouloumos
left a comment
kouloumos
left a comment
There was a problem hiding this comment.
The current implementation generates a separate log.csv file for each day, which complicates tasks such as reviewing logs from the past X days since it requires opening X different files. This approach is similarly cumbersome when trying to fetch logs for a specific scraper, as we might need to do after (or as part of) bitcoinsearch/bitcoinsearch-app#137.
Switching to a single .csv file per scraper would streamline this process. By including an ISO 8601 timestamp as the first column in the .csv file - consistent with the created_at field in the Elasticsearch documents - logs can be more easily filtered and accessed based on both time and scraper.
…-logs # Conflicts: # bitcoinops/main.py # common/elasticsearch_utils.py
kouloumos
force-pushed
the
master
branch
16 times, most recently
from
a4bd36f to
2112dad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a scraper logs for each Scraper in an individual csv file