PR: Updated README for local Elastic Search, And Refactor Elastic Search Config#82
Conversation
elraphty
changed the title
kouloumos
left a comment
kouloumos
left a comment
There was a problem hiding this comment.
looks good, I left a small nit for the import of all env variables from config
| from config.conf import INDEX_NAME, DATA_DIR | ||
|
|
||
| BASE_DIR = os.getenv("DATA_DIR", ".") | ||
| if __name__ == "__main__": | ||
| BASE_DIR = os.getenv(DATA_DIR, ".") |
There was a problem hiding this comment.
you can also import BASE_DIR from config.conf.
Additionally, if you wanted to do the config a bit more flexible you could structure it like this one here, but I don't consider it a must for now.
There was a problem hiding this comment.
you can also import
BASE_DIRfromconfig.conf.Additionally, if you wanted to do the config a bit more flexible you could structure it like this one here, but I don't consider it a must for now.
Okay, thanks @kouloumos
Thanks @kouloumos I have moved BASE_DIR to the config/conf.py |
It seems that As I said, this is a nit, but we already started discussing it, so let's fix it and merge. |
Oh!, I thought they served different purposes, making an update now. |
There was a problem hiding this comment.
I think that main.js contains code that we are not using anymore, as we transitioned to main.py, so maybe we can delete both package.json, yarn.lock and main.js as part of this PR?
- Refactored the elastic search connection to be able connect to local and production - It also updated the README file - And added a config package to be used by other scrapper packages. - deleted unused javascript files from previous mailing-list implementation
2 participants
This PR: