Skip to content

[RPC] Give RPC commands more information about the RPC request#333

Merged
dgenr8 merged 4 commits into
bitcoinxt:masterfrom
dagurval:rpc_container
Feb 20, 2018
Merged

[RPC] Give RPC commands more information about the RPC request#333
dgenr8 merged 4 commits into
bitcoinxt:masterfrom
dagurval:rpc_container

Conversation

@dagurval
Copy link
Copy Markdown
Member

@dgenr8
Copy link
Copy Markdown
Member

dgenr8 commented Feb 20, 2018

Needs rebase

laanwj and others added 4 commits February 20, 2018 09:45
Split out methods to every module, apart from 'help' and 'stop' which
are implemented in rpcserver.cpp itself.

- This makes it easier to add or remove RPC commands - no longer everything that includes
    rpcserver.h has to be rebuilt when there's a change there.
- Cleans up `rpc/server.h` by getting rid of the huge cluttered list of function definitions.
- Removes most of the bitcoin-specific code from rpcserver.cpp and .h.

Continues #7307 for the non-wallet.
This is more consistent with `JSONRPCReplyObj`.
@dagurval
Copy link
Copy Markdown
Member Author

rebased

@dgenr8 dgenr8 self-requested a review February 20, 2018 17:59
@dgenr8 dgenr8 merged commit def66a0 into bitcoinxt:master Feb 20, 2018
@dgenr8 dgenr8 removed their request for review February 20, 2018 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants