Use correct PR branch in plz review #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
trotterdylan
force-pushed
the
plz.review/review/4913
branch
from
f5e4143 to
287473c
Compare
We were using the hardcoded branch name as the head branch in plz review instead of the one on the PR. Most of the time that logic is correct, but if we want to support arbitrary branch names then we need to use the one attached to the PR. plz-review-url: https://plz.review/review/4913
plz-review
bot
force-pushed
the
plz.review/review/4913
branch
from
287473c to
4dfb5e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the hardcoded branch name as the head branch in plz review
instead of the one on the PR. Most of the time that logic is correct, but if we
want to support arbitrary branch names then we need to use the one attached to
the PR.
plz-review-url: https://plz.review/review/4913