Implement basic plz sync command #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
trotterdylan
force-pushed
the
plz.review/review/4913
branch
from
f5e4143 to
287473c
Compare
trotterdylan
force-pushed
the
plz.review/review/4914
branch
from
751f5cb to
b8a8502
Compare
plz-review
bot
force-pushed
the
plz.review/review/4913
branch
from
287473c to
4dfb5e2
Compare
The command operates as follows: * Fetch the review associated with the current commit * Traverse up the stack by fetching that review's latest revision's parent * Traverse each of these reviews in reverse order and do: - syncReviewWithParent to update the review - If an update happened, fetch the updated remote branch * Update the current HEAD branch to point to the top of the stack. Basically it works its way up the stack, updating each review upon the last. In the event that a parent review was merged, rebased, etc. then the child review will be rebased accordingly. At the end of this process, the whole stack of reviews will be up to date on plz.review, and the origin branches in the local repo will be up to date with GitHub. What this command does *not* do is incorporate any local changes. I have some ideas but it's still a little fuzzy how best to handle it in an intuitive way. plz-review-url: https://plz.review/review/4914
plz-review
bot
force-pushed
the
plz.review/review/4914
branch
from
b8a8502 to
6a2ca4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command operates as follows:
Basically it works its way up the stack, updating each review upon the last.
In the event that a parent review was merged, rebased, etc. then the child
review will be rebased accordingly. At the end of this process, the whole
stack of reviews will be up to date on plz.review, and the origin branches in
the local repo will be up to date with GitHub.
What this command does not do is incorporate any local changes. I have some
ideas but it's still a little fuzzy how best to handle it in an intuitive way.
plz-review-url: https://plz.review/review/4914