Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ object Capture {
/**
* Initializes fatal issue (ANR, JVM Crash, Native crash) reporting mechanism.
*
* @param fatalIssueMechanism the [FatalIssueMechanism] to use for crash detection
* @param context an optional context reference. You should provide the context if called from a [android.content.ContentProvider]
*
* This should be called prior to Capture.Logger.start()
Expand All @@ -111,8 +112,8 @@ object Capture {
@JvmStatic
@JvmOverloads
fun initFatalIssueReporting(
fatalIssueMechanism: FatalIssueMechanism = FatalIssueMechanism.BuiltIn,
context: Context? = null,
fatalIssueMechanism: FatalIssueMechanism,
) {
if (context == null && !ContextHolder.isInitialized) {
Log.w(LOG_TAG, "Attempted to initialize Fatal Issue Reporting with a null context. Skipping enabling crash tracking.")
Expand Down
2 changes: 1 addition & 1 deletion platform/swift/source/Capture.swift
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ extension Logger {
/// This API is experimental and subject to change
///
/// - parameter type: mechanism for crash detection
public static func initFatalIssueReporting(_ type: IssueReporterType = .customConfig) {
public static func initFatalIssueReporting(_ type: IssueReporterType = .builtIn) {
if issueReporterInitResult.0 != .notInitialized {
log(level: .warning, message: "Fatal issue reporting already being initialized")
return
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ final class FatalIssueReporterTests: XCTestCase {
}

func testNoConfig() {
Logger.initFatalIssueReporting()
Logger.initFatalIssueReporting(.customConfig)
let result = Logger.issueReporterInitResult
XCTAssertEqual(IssueReporterInitState.initialized(.missingConfigFile), result.0)

Expand All @@ -53,7 +53,7 @@ final class FatalIssueReporterTests: XCTestCase {

func testNoConfigDir() {
try! FileManager.default.removeItem(at: reportDir)
Logger.initFatalIssueReporting()
Logger.initFatalIssueReporting(.customConfig)
let result = Logger.issueReporterInitResult
XCTAssertEqual(IssueReporterInitState.initialized(.missingConfigFile), result.0)

Expand All @@ -64,7 +64,7 @@ final class FatalIssueReporterTests: XCTestCase {

func testBrokenConfig() {
createConfig("some nonsense")
Logger.initFatalIssueReporting()
Logger.initFatalIssueReporting(.customConfig)
let result = Logger.issueReporterInitResult
XCTAssertEqual(IssueReporterInitState.initialized(.malformedConfigFile), result.0)

Expand All @@ -79,7 +79,7 @@ final class FatalIssueReporterTests: XCTestCase {
directory: "the-files/special",
filename: "something.yam",
contents: String(repeating: "<stuff>", count: 100))
Logger.initFatalIssueReporting()
Logger.initFatalIssueReporting(.customConfig)
let result = Logger.issueReporterInitResult
XCTAssertEqual(IssueReporterInitState.initialized(.withoutPriorCrash), result.0)

Expand All @@ -97,7 +97,7 @@ final class FatalIssueReporterTests: XCTestCase {
filename: "something.json",
contents: initContents,
attributes: [.modificationDate: modDate])
Logger.initFatalIssueReporting()
Logger.initFatalIssueReporting(.customConfig)
let result = Logger.issueReporterInitResult
XCTAssertEqual(IssueReporterInitState.initialized(.sent), result.0)
XCTAssertLessThan(result.1, 50)
Expand Down Expand Up @@ -140,7 +140,7 @@ final class FatalIssueReporterTests: XCTestCase {
filename: "old-and-ignore.json",
contents: String(repeating: "<bad stuff>", count: 100),
attributes: [.modificationDate: modDate - TimeInterval(200)])
Logger.initFatalIssueReporting()
Logger.initFatalIssueReporting(.customConfig)
let result = Logger.issueReporterInitResult
XCTAssertEqual(IssueReporterInitState.initialized(.sent), result.0)
XCTAssertLessThan(result.1, 50)
Expand Down
Loading