Skip to content

fix(ios): avoid referencing logger during init #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

fix(ios): avoid referencing logger during init #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions platform/swift/source/Capture.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,11 @@ extension Logger {
/// - parameter type: mechanism for crash detection
static func initFatalIssueReporting(_ type: IssueReporterType = .builtIn) {
if issueReporterInitResult.0 != .notInitialized {
log(level: .warning, message: "Fatal issue reporting already being initialized")
return
}

issueReporterInitResult = (.initializing, 0)
guard let outputDir = Logger.reportCollectionDirectory() else {
log(level: .warning, message: "Fatal issue reporting output directory not defined, cannot enable reporting")
issueReporterInitResult = (.initialized(.missingReportsDirectory), 0)
return
}
Expand All @@ -126,7 +124,6 @@ extension Logger {
switch type {
case .builtIn:
#if targetEnvironment(simulator)
log(level: .info, message: "Fatal issue reporting disabled for simulated devices")
return .initialized(.unsupportedHardware)
#else
let reporter = DiagnosticEventReporter(outputDir: outputDir, sdkVersion: capture_get_sdk_version())
Expand Down
Loading