[CI][ANDR] Add Gradle plugin to check against non-permitted licenses #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murki
commented
Aug 24, 2024
| allowedLicensesFile = project.rootProject.file("allowed-licenses.json") | ||
| renderers = arrayOf(JsonReportRenderer()) | ||
| filters = arrayOf(SpdxLicenseBundleNormalizer()) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
^ here we centralize the plugin logic using gradle's precompiled convention plugins https://docs.gradle.org/current/userguide/custom_plugins.html
murki
commented
Aug 24, 2024
| implementation(libs.androidx.startup.runtime) | ||
| implementation(libs.jsr305) | ||
| implementation(libs.gson) | ||
| implementation("androidx.tracing:tracing-ktx:1.2.0") |
murki
commented
Aug 24, 2024
| "moduleName": "capture-sdk:replay" | ||
| } | ||
| ] | ||
| } No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
^ this is the list of allowed licenses
murki
commented
Aug 24, 2024
.github/workflows/android.yaml
Outdated
| run: ./gradlew capture-timber:testReleaseUnitTest --info | ||
| - name: Check Licenses for all Modules | ||
| working-directory: ./platform/jvm | ||
| run: ./gradlew checkLicense --info |
Contributor
Author
There was a problem hiding this comment.
^ run the check in CI
mattklein123
approved these changes
Aug 25, 2024
Contributor
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Nice, LGTM modulo CI issues.
murki
changed the title
murki
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using https://github.com/jk1/Gradle-License-Report to guard using non-allowed licenses. Applies common configuration to modules ':capture', ':capture-apollo3', ':capture-timber', ':common', ':replay'
Usage:
(needs to be in
cd platform/jvm)./gradlew checkLicense(checks all modules againstallowed-licenses.json)./gradlew capture:generateLicenseReport(generates reports inloop-sdk/platform/jvm/{$projectDir}/build/reports/dependency-license/)To get the full dependency tree for a module you can run:
./gradlew capture:dependencies --configuration releaseRuntimeClasspath