Simplifying apk size reporting #512
Conversation
FranAguilera
force-pushed
the
franjam/apk-size-improvements
branch
from
cf199d8 to
0caddf6
Compare
FranAguilera
force-pushed
the
franjam/apk-size-improvements
branch
3 times, most recently
from
337fc21 to
a18b36a
Compare
FranAguilera
force-pushed
the
franjam/apk-size-improvements
branch
from
4659ed4 to
f7546bc
Compare
FranAguilera
force-pushed
the
franjam/apk-size-improvements
branch
2 times, most recently
from
75b7c9b to
500cc0d
Compare
FranAguilera
force-pushed
the
franjam/apk-size-improvements
branch
from
500cc0d to
da8fe5f
Compare
| cp ./bazel-bin/examples/android/android_app.apk bazel_apk_baseline/ | ||
| APK_PATH=$(find bazel-bin/examples/android -name "android_app.apk" | head -n 1) | ||
| SIZE_FILE=ci/hello_world_bazel_x86_64_main_size.txt | ||
| stat -c%s "$APK_PATH" > "$SIZE_FILE" |
There was a problem hiding this comment.
could we take advantage of the effort you're putting revisiting all this and compute the aar / so size instead?
There was a problem hiding this comment.
totally, will explore. My main concern is increased build time but i can try to optimize other places
There was a problem hiding this comment.
yeah I think building the aar with a stripped so in parallel should be what we use to measure
There was a problem hiding this comment.
you can add it as a pre-step for Build Bazel APK and then I think you can use the generated aar for the //examples/android:android_app apk generation?
There was a problem hiding this comment.
perfect, will do as a follow up (had this already wip https://github.com/bitdriftlabs/capture-sdk/pull/378/files)
will be merging this soon (after more verification), to prevent broken state on main with that caching issue
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
FranAguilera
force-pushed
the
franjam/apk-size-improvements
branch
from
ba7e4c4 to
6a2e95e
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
FranAguilera
force-pushed
the
franjam/apk-size-improvements
branch
2 times, most recently
from
792c8cd to
913f2ca
Compare
FranAguilera
force-pushed
the
franjam/apk-size-improvements
branch
from
913f2ca to
c2a4fc4
Compare
📦 Bazel APK(x86_64) Size Report
|
What
Relying on
uses: actions/cache/save@v3seems flaky as often times we can get errors likeProposal here is to store the size on a file under ci directory
NOTE: As a follow up will handle aar size via script https://github.com/bitdriftlabs/capture-sdk/pull/378/files
Verification
Run without main check by commenting locally
if: github.ref == 'refs/heads/main' && success()so we can have the size being store logic run.