[ANDR][dev] Run lint on every project and apply same config everywhere #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Augustyniak
approved these changes
Aug 28, 2024
Contributor
Augustyniak
left a comment
Augustyniak
left a comment
There was a problem hiding this comment.
worked for me with your changes, thanks!
| @@ -1,7 +1,9 @@ | |||
| plugins { | |||
| // The rust android gradle plugin needs to go first | |||
| // see: https://github.com/mozilla/rust-android-gradle/issues/147 | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // see: https://github.com/mozilla/rust-android-gradle/issues/147 | |
| // see: https://github.com/mozilla/rust-android-gradle/issues/147 |
| } | ||
|
|
||
| // TODO(murki): Move this common configuration to a reusable buildSrc plugin once it's fully supported for kotlin DSL | ||
| // see: https://github.com/gradle/kotlin-dsl-samples/issues/1287 |
Contributor
There was a problem hiding this comment.
Suggested change
| // see: https://github.com/gradle/kotlin-dsl-samples/issues/1287 | |
| // see: https://github.com/gradle/kotlin-dsl-samples/issues/1287 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify (and make fwd compatible) the lint gradle task configuration on the
gradle-test-app. Also run the same configuration in all of our artifact modules (and suppress any existing warnings).In order to make this work we had to downgrade gradle from 8.3 --> 8.2 due to this open bug: https://issuetracker.google.com/issues/332755363