[WIP] add a timeout to the blocking log write #125
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid potentially blocking for a long time, add a fixed timeout for how long we'll block a log for
FranAguilera
force-pushed
the
blocking-log-timeout
branch
from
a55b5bc to
e521f5e
Compare
Revert "Trying to fix `logger.flush(true)`" This reverts commit e521f5e. Revert api changes
FranAguilera
force-pushed
the
blocking-log-timeout
branch
from
e521f5e to
af7043a
Compare
Contributor
|
Still WIP |
FranAguilera
changed the title
FranAguilera
reviewed
Jun 4, 2025
| if let Some(rx) = completion_rx { | ||
| let handle = tokio::runtime::Handle::current(); | ||
| let result = handle.block_on(async { | ||
| tokio::time::timeout(BLOCKING_FLUSH_TIMEOUT_SECONDS, rx.recv()).await |
Contributor
There was a problem hiding this comment.
Pending to update here as well
Contributor
|
this was really behind main and has tons of noise commits from me. Putting a new PR with the recent changes will link this one in description for future reference |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.