Add IAlternateLookup support to ClassicLru#742
Merged
Conversation
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/b637d9e9-a28d-4586-9ee4-fabcc2966bf1 Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
bitfaster
March 30, 2026 00:17
View session
bitfaster
reviewed
Mar 30, 2026
BitFaster.Caching/Lru/ClassicLru.cs
Outdated
|
|
||
| if (this.alternate.TryGetValue(key, out var node)) | ||
| { | ||
| this.lru.LockAndMoveToEnd(node); |
Owner
There was a problem hiding this comment.
@copilot extract the body of this if statement into a member function to avoid code duplication. Apply the same change to the other member functions of this struct. The newly extracted member functions should be inlined to make them fast.
Contributor
Author
There was a problem hiding this comment.
Extracted three shared inlined helpers on ClassicLru — TryGetNode, TryRemoveNode, and TryUpdateValue — each marked with [MethodImpl(MethodImplOptions.AggressiveInlining)]. Both the public ClassicLru methods (TryGet, TryRemove, TryUpdate, AddOrUpdate) and the AlternateLookup struct now call these shared helpers. Commit: 0c52d6e
…ClassicLru and AlternateLookup Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/e585fcf1-6b1d-4922-bc87-8b6fb552ce99 Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
bitfaster
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetAlternateLookup<TAlternateKey>()andTryGetAlternateLookup<TAlternateKey>()methods toClassicLru<K,V>(NET9_0_OR_GREATER)AlternateLookup<TAlternateKey>struct implementingIAlternateLookup<TAlternateKey, K, V>with TryGet, TryRemove, TryUpdate, AddOrUpdate, GetOrAdd, GetOrAdd<TArg>ClassicLruAlternateLookupTests.cs(9 tests - all passing)💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.