Add support for WithEvents to ConcurrentLfuBuilder#797
Merged
Conversation
added 2 commits
April 30, 2026 17:54
bitfaster
commented
May 1, 2026
Owner
Author
|
@copilot fix the failing tests. Do not make any changes except for fixing the tests. |
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/2b473ac9-fc97-4cd6-80cb-3cbf16918ba0 Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Contributor
Fixed in de473ca. The root cause was that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithEvents. Previously,ConcurrentLfudid not have events, so this preserves existing behavior for the builder.FastConcurrentLfuwhich uses theNoEventsPolicy. It supports both access order and time based expiry via generic parameters. This means we can have a single class for both expiry modes. Since this is internal, user cannot see the ugly generics. We can later consider providing publicFastConcurrentLfuandFastConcurrentTLfuand clean up the generics.