Add guarded LFU LRU integrity checks to soak tests#798
Merged
Conversation
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/56cc9c42-da32-457e-9721-89e01d25f4c4 Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/56cc9c42-da32-457e-9721-89e01d25f4c4 Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/56cc9c42-da32-457e-9721-89e01d25f4c4 Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
bitfaster
May 2, 2026 02:40
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LFU soak integrity check did not verify that each internal LRU list's stored count matched its actual contents. This adds count-vs-enumeration validation for the window, protected, and probation lists, with a guard to fail fast if list corruption or enumerator bugs cause non-terminating traversal.
What changed
windowprotectedprobationCount.Where
BitFaster.Caching.UnitTests/Lfu/ConcurrentLfuSoakTests.csConcurrentLfuIntegrityCheckerto assert list integrity before existing dictionary/list cross-checks.Failure mode covered
window,protected, orprobation) with targeted assertion messages.Example