Conversation
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/8f98a679-bba3-4e79-9126-334cc6d6b3c3 Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/8f98a679-bba3-4e79-9126-334cc6d6b3c3 Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
bitfaster
May 5, 2026 18:06
View session
bitfaster
reviewed
May 5, 2026
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net6.0</TargetFramework> |
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/eba74dbf-ac54-4703-8dbb-60eb3f2a3c1a Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Copilot
AI
changed the title
Suppress end-of-support framework build warnings for legacy target frameworks
Suppress legacy target framework build warnings and retarget tool projects to net10.0
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several projects still target
netcoreapp3.1andnet6.0for compatibility, which now surfaces end-of-support and unsupported-TFM build warnings. This change keeps builds clean by suppressing those specific warnings in the remaining legacy-targeted projects, while retargeting the tool projects that no longer neednet6.0tonet10.0.Scope
Project updates
CheckEolTargetFramework=falsewhere SDK EOL warnings (NETSDK1138) were emitted for executable/test projects that still target legacy frameworks.SuppressTfmSupportBuildWarnings=truewhere newer package dependencies emitted unsupported target framework warnings fornetcoreapp3.1/net6.0.Tools/HashTableSizeandTools/TrimVerification/BitFaster.Trimmedto targetnet10.0instead of suppressingnet6.0build warnings.Where this was applied
BitFaster.CachingBitFaster.Caching.UnitTestsBitFaster.Caching.UnitTests.StdBitFaster.Caching.Benchmarksnet10.0:Tools/HashTableSizeTools/TrimVerification/BitFaster.TrimmedImplementation shape
net10.0where legacy targeting is unnecessary.