-
-
Notifications
You must be signed in to change notification settings - Fork 21
Use ktor's HttpHeaders everywhere, and add warning about ktor-okhttp in README
#110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ktor's HttpHeaders everywhere, and add warning about ktor-okhttp in README
#110
Conversation
rfc2822
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of having a manually maintained annotation for Ktor dependencies. It looks error-prone and if we just forget a single thing (or forget to not use such annotated methods in DAVx5 code), everything breaks.
So considering that we want to transition to Ktor anyway, I think we can keep the ktor code for simplicity and just not exclude the ktor library in DAVx5.
And then hopefully make progress to move everything to ktor …
Maybe we just specify it in the comments? To be sure. Because with other functions it's clear (for example, they use a ktor reference in the arguments), but for others (such as they use |
However we'd then have to remove it again when we drop okhttp … I think we should keep ktor usage in common code as little as possible, but it's acceptable. We just need to know that Ktor must not be excluded in gradle. So maybe mention that in the README? That dav4jvm is currently in a rewrite phase to Ktor and that ktor must not be excluded. We can then update it when we remove okhttp from the dependencies. |
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
|
I've updated everything, and added a note to the README. Maybe the title of the PR should be updated now |
rfc2822
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a comment to the Ktor issue: #72 (comment)
|
We can also really remove the "requires Ktor" because the Ktor dependency is necessary anyway. |
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
|
Well, this PR has been simplified a lot, if not unnecessary. However, I still think the changes are important |
HttpHeaders everywhere, and add warning about ktor-okhttp in README
HttpHeadersfrom ktor everywhere