autogenerated versionName

[hannesa2]

Following the before-you-start I make this discussion.
I don't like this manual set of versionName and versionCode

davx5-ose/app-ose/build.gradle.kts

Lines 43 to 44 in 6c47d9f

	versionCode = 405120000
	versionName = "4.5.12-beta.1"

My idea is to make a pull request where this values are set automatically, similar to https://github.com/AppDevNext/AndroidChart/blob/master/app/build.gradle.kts#L17-L18

Ok, the versionCode need an addition of a magic number, to fit to existing way.
The versionName is under the hood the git describe --tags with an addition of -DIRTY if version was made with local un-commited changes.
e.g 5.2.1-1-g4cbc821fc-DIRTY

This would solve (just in the future), that I don't know anymore, which exact old apk I use.

Is it worth to make a pull request here ?

[rfc2822]

I don't like this manual set of versionName and versionCode

Why not? Can you please explain a bit about the motivation? Is it about the versioning scheme itself or just where the values are taken from?

Changing the versioning schema or configuration is a very critical thing and can break a lot of other things. So it should be done with great care.

The versionName is under the hood the git describe --tags with an addition of -DIRTY if version was made with local un-commited changes.

That always requires the code to come from a git repository. What if you for instance just download the tar.gz from Github?

We also have another additional challenge because we have two repositories: davx5-ose and davx5 for the other (gplay, managed, ...) builds. These have different commit IDs for the same core (the core gradle subproject is always taken from davx5-ose).

There's an internal issue that should make sure that davx5-ose and davx5 versioning are always aligned. Currently they're aligned manually.

This would solve (just in the future), that I don't know anymore, which exact old apk I use.

Would it help to for instance include the commit ID (if taken from git) in the About dialog instead?

[hannesa2]

Is it about the versioning scheme itself or just where the values are taken from?

It's just where the values are taken from. Auto generated is in my point of view always better

... because we have two repositories: davx5-ose and davx5 ..

Ok, I know https://github.com/bitfireAT/davx5-ose but where is the other one ? As I don't know the sense and the limitation, I can only accept like it is

What if you for instance just download the tar.gz from Github?

That's a complete unicorn, I just say a CI is your friend ! I at least never did that since the last 20 years. If I could decide this, I would not support it (anymore)

Would it help to for instance include the commit ID (if taken from git) in the About dialog instead?

Sure, this would be the cheapest solution, but it needs a git repository as well

[rfc2822]

It's just where the values are taken from. Auto generated is in my point of view always better

True

Ok, I know https://github.com/bitfireAT/davx5-ose but where is the other one ? As I don't know the sense and the limitation, I can only accept like it is

It's a private one and contains the additions for variants like davx5-gplay and more importantly davx5-managed.

That's a complete unicorn, I just say a CI is your friend ! I at least never did that since the last 20 years. If I could decide this, I would not support it (anymore)

I don't know what users do. I just want to say that changes should be prepared for the case that there's no underlying git repo and for instance print a proper error message in that case.

Sure, this would be the cheapest solution, but it needs a git repository as well

Yes, I'd use a fallback string like "not from git" if the commit ID is not available.

If that still fits your needs, I'd vote for such a PR, especially because it wouldn't change our current release process. We could still make more use of that at a later time.

Which API would you use to get the git commit into the view? I guess some gradle plugin → define resString in core → print that string in the About view?

[hannesa2]

Which API would you use to get the git commit into the view? I guess some gradle plugin

Just *.kts, no plugin needed

I guess some gradle plugin → define resString in core → print that string in the About view?

No need, I only want to change the versionName versionCode

[hannesa2]

#2195

[hannesa2]

Just some words about my motivation and maybe you understand why I want to have a exact versionName
As you can see I followed your journey from gitlab to github

Currently I use ownCloud and make the switch to Nextcloud, but my version doesn't work with Nextcloud 👎 so unfortunately I've to do something.
But I forgot from where my current version exactly is

Btw, in my point of view, in the past there was too much fragmentation and confusion

[hannesa2]

Yes, it would change your current build system. This is intended !
I assume you have the same current manual logic in both repositories.
I don't get your point of a limitation of multiple repositories, because it still use your current number logic, just set same tag on both repositories and you are fine.