Skip to content

[bitnami/mongodb]: Use merge helper#19082

Merged
juan131 merged 2 commits intobitnami:mainfrom
juan131:fix/mongodb-merge
Sep 7, 2023
Merged

[bitnami/mongodb]: Use merge helper#19082
juan131 merged 2 commits intobitnami:mainfrom
juan131:fix/mongodb-merge

Conversation

@juan131
Copy link
Contributor

@juan131 juan131 commented Sep 5, 2023

Description of the change

This PR follows up #18889 adapting the chart to use the new helper common.tplvalues.merge donated by @jouve to merge annotations & labels.

Benefits

Chart to be compatible with values with string templates & dicts, so both the formats below can be used:

podLabels:
  foo: "bar"
  app.kubernetes.io/name: "{{ join \"-\" (list \"prefix\" .Release.Name)  }}"
podLabels: |
  {{ include "XXX.labels" . }}

Possible drawbacks

None

Applicable issues

N/A

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: juan131 <jariza@vmware.com>
Signed-off-by: juan131 <jariza@vmware.com>
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Sep 5, 2023
@juan131 juan131 merged commit d7ea4e9 into bitnami:main Sep 7, 2023
@github-actions github-actions bot added the solved label Sep 7, 2023
@juan131 juan131 deleted the fix/mongodb-merge branch September 7, 2023 10:24
jouve pushed a commit to jouve/bitnami-charts that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bitnami mongodb solved verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants