[bitnami/mlflow] feat: Fixup to allow database dialects to be configured (#25965)#28316
Merged
juan131 merged 2 commits intobitnami:mainfrom Jul 24, 2024
Merged
[bitnami/mlflow] feat: Fixup to allow database dialects to be configured (#25965)#28316juan131 merged 2 commits intobitnami:mainfrom
juan131 merged 2 commits intobitnami:mainfrom
Conversation
…red (bitnami#25965) This is a fixup for the auth database URI generation. The previous commit PR bitnami#25965 did not apply the dialect template / config to the uri of the auth database. Fixes: bitnami#25965 Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
4 tasks
Contributor
Author
|
@juan131 PTAL. |
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
juan131
approved these changes
Jul 24, 2024
Contributor
juan131
left a comment
juan131
left a comment
There was a problem hiding this comment.
Thanks for the fix! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This is a fixup for the auth database URI generation. The previous commit PR #25965
did not apply the dialect template / config to the uri of the auth database.
Fixes: #25965
Fixes: #25964
Signed-off-by: Christian Rohmann christian.rohmann@inovex.de
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm