fix Script.set

[fanatid]

Original PR: bitpay/bitcore#1346

[eordano]

Just bumped into this issue. Can we merge it?

CC: @braydonf

[braydonf]

The original PR mentioned tx.outputs[1].script as being null.

var script = bitcore.Script(tx.outputs[1].script)

However tx.outputs[1].script should already be an instance of Script if it's able to be parsed, otherwise it will return null, and using the raw buffer is necessary ._scriptBuffer, and in that case var script = bitcore.Script(tx.outputs[1]._scriptBuffer) will throw an error.

Edit: And why checking the value before using it is necessary, e.g. https://github.com/bitpay/bitcore-node/blob/master/lib/services/address/index.js#L492

Is that the issue?

[matiu]

ACK

[fanatid]

1 day before 2 year old 🎉