This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Script: Account for reverseMap name inconsistencies #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 13, 2015 14:25
There are a few cases where the opcode name doesn't match the name exactly. These are mostly related with data pushes, and the cases for `OP_0` and `OP_1NEGATE` were not handled as data pushes as the buf.length was 0. This adds these exceptions to the `_chunkToString` method on Script. References: - https://github.com/bitcoin/bitcoin/blob/e54ebbf6009716a7abcd4d8d3f7bd910e88decdc/src/script/script.cpp#L13 - https://github.com/bitcoin/bitcoin/blob/e54ebbf6009716a7abcd4d8d3f7bd910e88decdc/src/core_write.cpp#L75
braydonf
changed the title
|
Hello, can you merge this fix please? I want to switch to new insight-api, but I can't use it because of this issue. Thank you |
|
Any news about merging this fix? |
Contributor
Author
|
I'll take another pass at this, to verify, and see if we can move this forward. |
Contributor
Author
|
FYI, this shouldn't affect insight-api or bitcore-node, as the ASM is from bitcoind directly now. |
Prtfw
referenced
this pull request
in dashpay/dashcore-lib
Jul 3, 2017
Add new method getblockdeltas
Contributor
|
ACK |
shohu
pushed a commit
to c0banparty/bitcore-lib-c0ban
that referenced
this pull request
Nov 5, 2018
Script: Account for reverseMap name inconsistencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few cases where the opcode name doesn't match the name exactly.
These are mostly related with data pushes, and the cases for
OP_0andOP_1NEGATEwerenot handled as data pushes as the buf.length was 0. This adds these exceptions to the
_chunkToStringmethod on Script.References:
Closes: bitpay/insight-api#423