This repository was archived by the owner on Apr 3, 2019. It is now read-only.
No prefix via toCashAddress(false) #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabegattis
reviewed
Jan 31, 2018
|
|
||
|
|
||
| Address.prototype.toCashAddress = function() { | ||
| Address.prototype.toCashAddress = function(withPrefix) { |
There was a problem hiding this comment.
lets validate that withPrefix is a boolean if it exists
gabegattis
reviewed
Jan 31, 2018
lib/address.js
Outdated
|
|
||
| Address.prototype.toCashAddress = function() { | ||
| Address.prototype.toCashAddress = function(withPrefix) { | ||
| if(withPrefix === undefined || typeof(withPrefix) !== 'boolean') { |
There was a problem hiding this comment.
We want to throw if the argument is wrong type. It is better to complain than to silently accept something wrong.
micahriggan
force-pushed
the
feature/cashaddr-no-prefix-option
branch
4 times, most recently
from
dc11dfc to
a0bcc06
Compare
micahriggan
force-pushed
the
feature/cashaddr-no-prefix-option
branch
from
cbe289b to
d134252
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting a common use-case, the cash address without the prefix on it.