add Transaction#clearOutputs #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/transaction/transaction.js
Outdated
There was a problem hiding this comment.
Shouldn't this also call this._updateChangeOutput()? Otherwise all the inputs will be miner's fee.
maraoz
force-pushed
the
transaction/clearOutputs
branch
from
1873c53 to
8a13a22
Compare
|
updated |
|
LGTM |
|
ACK |
braydonf
pushed a commit
that referenced
this pull request
May 18, 2015
add Transaction#clearOutputs
|
Yay! On Mon, May 18, 2015, 17:24 Braydon Fuller notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
clearOutputs()method forTransactionthat removes all outputs.