This repository was archived by the owner on Jan 22, 2021. It is now read-only.
Fixes #72 - Restructured arb int math and enabled BCMath as an engine #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Bitpay/Math/BcEngine.php
Outdated
Contributor
There was a problem hiding this comment.
if you trim() the string above where you strtolower(), you can remove this conditional code branch. I.e. $x = strtolower(trim($x));
Contributor
There was a problem hiding this comment.
What if the merchant has gmp and not bcmath? I would suggest putting both of these in the suggest part of this file and update documentation to explain that one of these are needed.
Contributor
|
All in all, this looks pretty good. You might want to run it thru php-cs-fixer for some formatting issues, but I do not see anything obvious at first glance. |
ionux
added a commit
that referenced
this pull request
Nov 28, 2014
Fixes #72 - Restructured arb int math and enabled BCMath as an engine
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And this time shouldn't stall Travis CI