Skip to content
This repository was archived by the owner on Jan 22, 2021. It is now read-only.

Conversation

@aleitner
Copy link
Contributor

@aleitner aleitner commented Dec 1, 2014

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc block comments

@JoshuaEstes
Copy link
Contributor

Looks ok to me, I would like to see some type of code coverage within the foreach loop to make sure it does what it's suppose to do. Other than that, I think this is ok to merge in.

@ionux
Copy link
Contributor

ionux commented Dec 1, 2014

Has this been regression tested with any of our existing plugins?

@aleitner
Copy link
Contributor Author

aleitner commented Dec 1, 2014

I was able to create an invoice and pair using command line. I will move the card to build and do regression testing before it gets moved back to verify.

Alex Leitner
alex@bitpay.com

On Dec 1, 2014, at 2:28 PM, Rich Morgan notifications@github.com wrote:

Has this been regression tested with any of our existing plugins?


Reply to this email directly or view it on GitHub #126 (comment).

@aleitner
Copy link
Contributor Author

aleitner commented Dec 3, 2014

Paul and I got stuck going down the Rabbit hole trying to figure this out today. We having been trying to create customizable options that also make it easy to change from Livenet/Testnet to using a local instance of bitpay. The way we figured it out requires a Network object to be created before an Adapter Object. So we may just create a config file that has constants for set already. And you would change these constants instead of using all these different classes and setting properties in each object

@aleitner aleitner self-assigned this Dec 4, 2014
ionux added a commit that referenced this pull request Dec 4, 2014
Curl options can now be set in the adapter class
@ionux ionux merged commit 4ffd154 into bitpay:master Dec 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants