This repository was archived by the owner on Jan 22, 2021. It is now read-only.
Refund functionality and Issue fixes #129
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abishekrsrikaanth
commented
Dec 8, 2014
abishekrsrikaanth
commented
- Implemented Refund functionality
- Create Refund
- Get Refund By Invoice
- Cancel Refund By Invoice
- Get Refunds By Invoice
- Fixed issue Pairing Code property does not exist on the Token Class #128
- Added ability to retrieve the pairing code when creating a merchant pairing token
- Implemented Rates API
Fixed the CreateToken method to set the resource and pairing code if the response from the API contains them.
The closing brace for the class must go on the next line after the body
Line 184 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 7
Line 211 | ERROR | Whitespace found at end of line
Line 527 | ERROR | Expected "if (...) {\n"; found "if(...)\n {\n"
Line 532 | ERROR | Expected "if (...) {\n"; found "if(...)\n {\n"
Line 527 | ERROR | Expected "if (...) {\n"; found "if(...){\n"
Line 531 | ERROR | Expected "if (...) {\n"; found "if(...){\n"
src/Bitpay/Client/Client.php
Outdated
There was a problem hiding this comment.
add a trailing ,
no need to align the => is a good suggestion to avoid unnecessary diffs later on, same for ='s below
Added invoice::token, changed client::createRefund to use invoice tokens
- Get Refund - Cancel Refund - Get Refunds By Invoice Implemented Organization and OrganizationInterface
Fixed PHPCS issues
…e invoice Token retrieves the information about the invoice and not the refund
…rystring instead of on the Request Body
There was a problem hiding this comment.
Why catch and rethrow an \Exception?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.