E2e test PVCs #178
Merged
E2e test PVCs #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calind
requested changes
Dec 11, 2018
bogdanpetrea
suggested changes
Dec 14, 2018
bogdanpetrea
approved these changes
Dec 14, 2018
chapsuk
pushed a commit
to chapsuk/mysql-operator
that referenced
this pull request
Oct 16, 2023
…e#178) * Ensure that we allocate a new map to avoiding sharing memory, and copy over for safety for etcd case. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com> * Copy resources for vttablet pod since it contains pointers. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com> * We also use resources type for mysqld container. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com> * Safeguard everywhere else we use resources. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com> * Remove return so we fall through appropriately. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #172
This PR also fixes a bug that removes the PVC of pod-0 when the cluster is scaled down to 0.