Refactor sidecar command, add configs #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMecea
force-pushed
the
refactor-sidecar-2
branch
4 times, most recently
from
2de1e4d to
a5596bc
Compare
calind
requested changes
Mar 4, 2019
AMecea
force-pushed
the
refactor-sidecar-2
branch
from
60f5de4 to
af6f097
Compare
calind
requested changes
Mar 7, 2019
| // deactivate super read only | ||
| log.Info("temporary disable SUPER_READ_ONLY") | ||
| if err := util.RunQuery("SET GLOBAL READ_ONLY = 1; SET GLOBAL SUPER_READ_ONLY = 0;"); err != nil { | ||
| if err := runQuery(cfg, "SET GLOBAL READ_ONLY = 1; SET GLOBAL SUPER_READ_ONLY = 0;"); err != nil { |
Member
There was a problem hiding this comment.
Can we have the defer pattern here:
enableSuperReadOnly, err := disableSuperReadOnly()
defer enableSuperReadOnly()
Contributor
Author
There was a problem hiding this comment.
This PR does not introduce disableSuperReadOnly function. Only in #243 this function is added.
AMecea
force-pushed
the
refactor-sidecar-2
branch
from
af6f097 to
0e47237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #240