BITMAG-992 Human-readable intervals in reference settings #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ole-v-v
requested review from
Bohlski and
m-atlantis
and removed request for
Bohlski
ole-v-v
changed the title
m-atlantis
requested changes
Sep 7, 2022
...trail-service/src/main/java/org/bitrepository/audittrails/collector/AuditTrailCollector.java
Show resolved
Hide resolved
...-service/src/main/java/org/bitrepository/audittrails/preserver/LocalAuditTrailPreserver.java
Outdated
Show resolved
Hide resolved
bitrepository-core/src/main/java/org/bitrepository/common/utils/TimeUtils.java
Show resolved
Hide resolved
bitrepository-core/src/main/java/org/bitrepository/common/utils/TimeUtils.java
Show resolved
Hide resolved
Bohlski
reviewed
Sep 7, 2022
...java/org/bitrepository/client/conversation/mediator/CollectionBasedConversationMediator.java
Show resolved
Hide resolved
Bohlski
requested changes
Sep 7, 2022
...java/org/bitrepository/client/conversation/mediator/CollectionBasedConversationMediator.java
Outdated
Show resolved
Hide resolved
bitrepository-core/src/main/resources/examples/settings/ReferenceSettings.xml
Outdated
Show resolved
Hide resolved
bitrepository-core/src/main/resources/examples/settings/ReferenceSettings.xml
Outdated
Show resolved
Hide resolved
Bohlski
reviewed
Sep 7, 2022
bitrepository-service/src/main/java/org/bitrepository/service/workflow/WorkflowManager.java
Show resolved
Hide resolved
…nicely (after review)
Bohlski
approved these changes
Sep 9, 2022
Contributor
Bohlski
left a comment
Bohlski
left a comment
There was a problem hiding this comment.
Looks good! I fixed a small issue that occurred in the GUI, but otherwise it looks like everything's in order 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch builds on BITMAG-992-settings-human-intervals-reference, so merging it should probably await merging of that one.