BITMAG 1190: GUI preservation schedule shows wrong first 'next start' #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying bug has now been fixed. Included in this AuditTrailCollector and LocalAuditTrailPreserver now inherit from the new AuditTrailTaskStarter class, which allows similarities between the two to be abstracted away.
Both the TimerTasks for collection and preservation were set to wake 10 times within their intervals checking if it was time to do stuff and otherwise doing nothing. So waking 9 times with no purpose. No explaining comment as to why. Timer#scheduleAtFixedRate only schedules tasks on one thread, so scheduling more tasks than needed does not seem to have any benefit even if it was in case tasks were taking long to complete. The TimerTasks now only wake on their intervals.
m-atlantis
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been fixed along with changing audit trail collection/preservation TimerTasks to now only wake once on their respective intervals instead of waking 10 times for no apparent reason.